[release/6.0] SQLite: Don't modify collection while enumerating inside ReclaimLeakedConnections #27428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code to reclaim leaked connections inadvertently modifies a collection while enumerating.
Fixes #27168
Customer impact
Because of this defect, calling methods like
SqliteConnection.ClearAllPools()currently throws when an application fails to dispose connection objects.Regression
Yes. Pooling was added in 6.0 and is enabled by default. There's a new Timer that calls this code on a background thread every 2-4 minutes.
Risk
Low. The updated code more closely mirrors the existing code used by the ODBC, OLE DB, and SqlClient providers.
Verification
Added a new automated test to cover the scenario.